Make SI damage round naturally and have minimum of 1 #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed. |
Sleet01
added
the
In Development (Draft)
|
Confirmed that heat-only weapons do not now apply minimum 1 damage to SI of heat-tracking Aerospace units (to wit, AeroSpaceFighters). Also further confirmed appropriate application of 1 SI damage from single damage clusters such as:
This PR is ready to be pulled. |
Sleet01
removed
the
In Development (Draft)
neoancient
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the ruling here: https://bg.battletech.com/forums/index.php?topic=81913.0
and confirmed on the CGL Discord here: https://discord.com/channels/1157414258133442710/1200547291321339924/1220749492773720195
Aerospace SI damage should be rounded naturally to a minimum of 1.
This patch implements that functionality.
Testing:
Close #5273